Added additional functionality #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2012 12:45
surrounding configurations, classifiers, and a couple of other miscellaneous things.
|
I added some comments to the diff about the changes. |
|
I'd highly recommend resubmitting with the project's preferred tabbing style. It's impossible to tell what is a change and what is just reformatting. Likewise, why would the project maintainer want to accept this pull request if it'll just make the change his formatting inconsistent. There's probably 18 good lines buried here. |
|
For the reason described by quidryan, instead of pulling I made new branch nsteffan-manual and manually merged in only the effective code changes. After merging in this code, test case "artifact" fails. If you resolve that issue, I'll merge the enhancement into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of updates to the Ivyxml plugin to add additional functionality surrounding configurations, classifiers, and a couple of other miscellaneous things.